fix: fix text overflow in toast #17547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkdotson
requested review from
geido,
hughhhh,
michael-s-molina and
rusackas
Codecov Report
@@ Coverage Diff @@
## master #17547 +/- ##
==========================================
+ Coverage 77.00% 77.01% +0.01%
==========================================
Files 1049 1049
Lines 56588 56615 +27
Branches 7825 7847 +22
==========================================
+ Hits 43574 43602 +28
Misses 12760 12760
+ Partials 254 253 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The pr fixes an issue where the toast text, if very long, will overflow out of the container.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
TESTING INSTRUCTIONS
Go to any of the listviews and add an item with a very long name and delete the item and ensure that the text breaks within the toast.
ADDITIONAL INFORMATION